Disable docker layer caching in github action #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test actually ran 8 mins faster 👀 Was it the caching that was making it take so long? 😝 |
petertgiles
reviewed
Sep 29, 2022
|
@esizer Whaaaa! Bwahaha omg ok, maybe we should just remove it completely. That's wiiiild :) |
patcon
changed the title
|
I wonder if lack of disk space was causing tests to overrun timeouts... cursory impression is that this seems to be less failure-prone |
petertgiles
approved these changes
Sep 29, 2022
|
Thanks @petertgiles and @mnigh! (And yeah Peter, the CI is kinda the evaluation for this stuff, I guess? In the future, I can explicitly say that in the "testing instructions" when that's the case..!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun out from: #4035 (comment) h/t @mnigh
This was causing e2e-tests to show as "skipped", and rarely showing the proper pass/fail status, which makes the e2e tests pretty useless.
Disabling docker layer cache for now, to avoid the github action "out of storage" error. We'll see in the github action run whether it makes the workflow run significantly longer (20-25 min seems to be regular).